Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[resource_datadog_metric_metadata] Clarify supported metric types #1404

Merged
merged 2 commits into from
Apr 6, 2022
Merged

[resource_datadog_metric_metadata] Clarify supported metric types #1404

merged 2 commits into from
Apr 6, 2022

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Apr 4, 2022

Clarify supported metric types, gauge, rate on the resource_datadog_metric_metadata document.
resource_datadog_metric_metadata depends on Edit metric metadata, so metric types must be gauge or rate. That should be documented.
Metrics 2022-04-04 at 2 14 21 PM

@keisku keisku requested review from a team as code owners April 4, 2022 05:25
maycmlee
maycmlee previously approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from docs.

@therve therve changed the title [resource_datadog_metric_metadata] clarify supported metric types [resource_datadog_metric_metadata] Clarify supported metric types Apr 6, 2022
@therve therve merged commit 121935d into master Apr 6, 2022
@therve therve deleted the keisku/resource_datadog_metric_metadata branch April 6, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

@maycmlee maycmlee maycmlee left review comments

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keisku @therve @maycmlee