[datadog_security_monitoring_rule] Update provider for detection method impossible travel #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffix
force-pushed
the
bjorn.marschollek/add-impossible-travel-rule
branch
2 times, most recently
from
c721f8a to
1c5f46d
Compare
Updates the provider for security monitoring rules to accept rules with the new detection method `impossible_travel`. See also: - DataDog/documentation#13204 - DataDog/datadog-api-client-go#1357
muffix
force-pushed
the
bjorn.marschollek/add-impossible-travel-rule
branch
from
1c5f46d to
37827a9
Compare
muffix
changed the title
muffix
changed the title
alai97
previously approved these changes
Apr 1, 2022
|
|
||
| Optional: | ||
|
|
||
| - **baseline_user_locations** (Boolean) If true, signals are suppressed for the first 24 hours. In that time, Datadog learns the user's regular access locations. This can be helpful to reduce noise and infer VPN usage or credentialed API access. Default is `false`. |
There was a problem hiding this comment.
Suggested change
| - **baseline_user_locations** (Boolean) If true, signals are suppressed for the first 24 hours. In that time, Datadog learns the user's regular access locations. This can be helpful to reduce noise and infer VPN usage or credentialed API access. Default is `false`. | |
| - **baseline_user_locations** (Boolean) If true, signals are suppressed for the first 24 hours. Datadog uses this time to learn about the user's regular access locations. This is helpful to reduce noise and infer VPN usage or credentialed API access. Default is `false`. |
pietrodll
previously approved these changes
Apr 5, 2022
alai97
previously approved these changes
Apr 5, 2022
jirikuncar
reviewed
Apr 7, 2022
Comment on lines
372
to
389
| metric = "@usr.handle" | ||
| group_by_fields = ["@usr.handle"] | ||
| } | ||
|
|
||
| case { | ||
| name = "" | ||
| status = "high" | ||
| notifications = ["@user"] | ||
| } | ||
|
|
||
| options { | ||
| detection_method = "impossible_travel" | ||
| keep_alive = 600 | ||
| max_signal_duration = 900 | ||
| impossible_travel_options { | ||
| baseline_user_locations = true | ||
| } | ||
| } |
There was a problem hiding this comment.
@muffix can you please reformat it?
jirikuncar
reviewed
Apr 7, 2022
Comment on lines
445
to
461
| metric = "@usr.handle" | ||
| group_by_fields = ["@usr.handle"] | ||
| } | ||
|
|
||
| case { | ||
| name = "new case name (updated)" | ||
| status = "high" | ||
| notifications = ["@user"] | ||
| } | ||
|
|
||
| options { | ||
| detection_method = "impossible_travel" | ||
| keep_alive = 600 | ||
| max_signal_duration = 900 | ||
| impossible_travel_options { | ||
| baseline_user_locations = true | ||
| } |
There was a problem hiding this comment.
@muffix can you please reformat it?
therve
approved these changes
Apr 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the provider for security monitoring rules to accept rules with
the new detection method
impossible_travel.See also: