Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_monitor] Mark locked as deprecated #1400

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

phillip-dd
Copy link
Contributor

With monitor restricted roles being GA, this marks the previous locked as deprecated.

@DataDog/monitor-app

@phillip-dd phillip-dd requested review from a team as code owners March 31, 2022 14:27
gkharkwal
gkharkwal previously approved these changes Mar 31, 2022
jtappa
jtappa previously approved these changes Mar 31, 2022
Copy link
Contributor

@jtappa jtappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 from docs team

@therve therve changed the title [monitor] Mark locked as deprecated. [datadog_monitor] Mark locked as deprecated Apr 1, 2022
@phillip-dd phillip-dd dismissed stale reviews from jtappa and gkharkwal via 997db4d April 1, 2022 16:29
@phillip-dd phillip-dd force-pushed the pb/restricted-roles branch from 59b93a4 to 997db4d Compare April 1, 2022 16:29
@therve therve marked this pull request as draft April 1, 2022 19:05
@therve therve marked this pull request as ready for review April 1, 2022 19:05
@therve therve merged commit b3d4814 into master Apr 5, 2022
@therve therve deleted the pb/restricted-roles branch April 5, 2022 06:41
@martinb3
Copy link

FYI I think this locked attribute may now be rejected by the Datadog monitoring API, and any previous monitor that has locked in the state, even if it's no longer specified, may be failing to update?

#2327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants