Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Add certificate check option for ssl tests #1368

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

romainberger
Copy link
Member

Add a missing option for Synthetics SSL tests.

@romainberger romainberger requested review from a team as code owners February 24, 2022 10:15
Copy link
Contributor

@AlaricCalmette AlaricCalmette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you removed all the convertToString but lgtm

@romainberger
Copy link
Member Author

Not sure why you removed all the convertToString but lgtm

They were all used for the legacy options format that is not used anymore, I supposed it was forgotten to clean when the old format got removed.

@skarimo skarimo merged commit 06f862a into master Mar 2, 2022
@skarimo skarimo deleted the rberger/SYA-1466/synthetics-ocsp-option branch March 2, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants