Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PagerDuty Integration Resource #135

Merged
merged 7 commits into from
Jan 9, 2019

Conversation

ls339
Copy link
Contributor

@ls339 ls339 commented Dec 11, 2018

What does this PR do?

Creates a new PagerDuty Integration resource from commits here:
https://github.com/terraform-providers/terraform-provider-datadog/pull/56

Who will it impact?

No one is yet using this resource.

Motivation

Manage Datadog PagerDuty integration configurations from terraform.

Copy link
Member

@yannmh yannmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thanks @rlhh and @ls339.

@masci would you be able to take a look at it?

* `service_name` - (Required) Your Service name in PagerDuty.
* `service_key` - (Required) Your Service name associated service key in Pagerduty.
* `schedules` - (Optional) Array of your schedule URLs.
* `subdomain` - (Required) Your PagerDuty account’s personalized subdomain name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subdomain is only required for the "crawler" part of the integration right? If that's the case, it's is not more required than the API token is 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct, the subdomain in only required by the crawler. Here in the terraform provider context, its being used as a unique identifier for the resource schema.


### See also
* [PagerDuty Integration Guide](https://www.pagerduty.com/docs/guides/datadog-integration-guide/)
* [Datadog API Reference > Integrations > PagerDuty](https://docs.datadoghq.com/api/?lang=bash#pagerduty)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation looks good to me 🙇

@jeremyolliver
Copy link

This looks like it supersedes #56 ?

@masci masci added this to the 1.7.0 milestone Jan 9, 2019
@masci masci merged commit 92c4871 into DataDog:master Jan 9, 2019
jbenais pushed a commit to jbenais/terraform-provider-datadog that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants