Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Integration: Add support for metrics and resource collections #1343

Merged
merged 8 commits into from
Feb 18, 2022
Merged

AWS Integration: Add support for metrics and resource collections #1343

merged 8 commits into from
Feb 18, 2022

Conversation

nikohaa
Copy link
Contributor

@nikohaa nikohaa commented Feb 3, 2022 •
edited
Loading

Add support metrics and resource collections for datadog_integration_aws resource

Added fields:

  • resource_collection_enabled
  • metrics_collection_enabled
  • cspm_resource_collection_enabled

@nikohaa nikohaa requested review from a team as code owners February 3, 2022 08:49
maycmlee
maycmlee reviewed Feb 3, 2022
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix

docs/resources/integration_aws.md Outdated Show resolved Hide resolved
jvanbrie
jvanbrie reviewed Feb 3, 2022
View reviewed changes
Copy link

@jvanbrie jvanbrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for these! Could we add cspm_collection_enabled at the same time?

skarimo
skarimo reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@skarimo skarimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr! Left 2 minor comments

datadog/resource_datadog_integration_aws.go Outdated Show resolved Hide resolved
datadog/resource_datadog_integration_aws.go Show resolved Hide resolved
nikohaa and others added 2 commits February 4, 2022 10:11
@nikohaa @skarimo
Update datadog/resource_datadog_integration_aws.go
23da38c 
Set metrics_collection_enabled to true as a default

Co-authored-by: skarimo <[email protected]>
@nikohaa
Add new field and fix acc tests:
f2f2975 
* Add cspm_resource_collection_enabled field
* Update docs
* Fix acc tests cases
@skarimo skarimo force-pushed the add-support-for-aws-integration-collection-fetures branch from acf589f to 9da47b9 Compare February 4, 2022 21:58
@skarimo
Copy link
Member

skarimo commented Feb 4, 2022

Thanks for the pr made a few small changes and pushed up cassettes. Primary change was not checking if the attributes is set or not. The GetOk method does not work well with zero values.

maycmlee
maycmlee previously approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@skarimo skarimo merged commit 4a4fe40 into DataDog:master Feb 18, 2022
@nikohaa nikohaa deleted the add-support-for-aws-integration-collection-fetures branch February 25, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo left review comments

@jvanbrie jvanbrie jvanbrie left review comments

@therve therve therve approved these changes

@maycmlee maycmlee maycmlee left review comments

Assignees
No one assigned
Labels
changelog/improvement ci/integrations resource/datadog_integration_aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikohaa @skarimo @therve @maycmlee @jvanbrie