Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform support for Cloud Workload Security Agent Rules #1338

Merged
merged 15 commits into from
Feb 1, 2022

Conversation

andpiccione
Copy link
Contributor

This PR adds support for creating/updating/deleting/fetching Cloud Workload Security Agent rules. See related API reference for documentation.

@andpiccione andpiccione requested a review from a team as a code owner January 27, 2022 18:05
@andpiccione
Copy link
Contributor Author

andpiccione commented Jan 27, 2022

FYI, I created a new label resource/datadog_cloud_workload_security_agent_rul (missing e at the end because character limit for labels is 50). I hope it's ok, I can modify it if you prefer.

@andpiccione andpiccione requested review from a team and z-grab and removed request for a team January 27, 2022 18:40
kayayarai
kayayarai previously approved these changes Jan 27, 2022
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from docs. In the generated .md files, there's a lot of inconsistency about whether Agent is capitalized. If this is referring to the Datadog Agent, it should be capitalized, throughout. Also, Cloud Workload Security should be capitalized (line 11, docs/data-sources/cloud_workload_security_agent_rules.md)

@andpiccione
Copy link
Contributor Author

👋 Hey @kayayarai, thanks for the review. I updated the docs to make sure that both the product name and Agent are capitalized. Feel free to let me know if there are any other inconsistencies.

@andpiccione andpiccione requested a review from skarimo January 28, 2022 18:46
@andpiccione andpiccione requested review from kayayarai and a team January 28, 2022 18:46
@therve
Copy link
Contributor

therve commented Feb 1, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants