Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support new authentication types and request proxy for Synthetics tests #1336

Merged
merged 8 commits into from
Feb 8, 2022
Merged

Add support new authentication types and request proxy for Synthetics tests #1336

merged 8 commits into from
Feb 8, 2022

Conversation

romainberger
Copy link
Member

Add new authentication types for API tests and request proxy for browser and api tests.

@romainberger romainberger requested review from a team as code owners January 25, 2022 06:12
AlaricCalmette
AlaricCalmette previously approved these changes Jan 25, 2022
View reviewed changes
@romainberger romainberger requested a review from a team as a code owner January 27, 2022 09:44
maycmlee
maycmlee reviewed Jan 27, 2022
View reviewed changes
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
docs/resources/synthetics_test.md Outdated Show resolved Hide resolved
skarimo
skarimo reviewed Feb 2, 2022
View reviewed changes
Copy link
Member

@skarimo skarimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Left a few nits but otherwise LGTM. Could you run make docs. Thanks

datadog/resource_datadog_synthetics_test_.go Outdated Show resolved Hide resolved
datadog/tests/resource_datadog_synthetics_test_test.go Outdated Show resolved Hide resolved
datadog/tests/resource_datadog_synthetics_test_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_synthetics_test_.go Show resolved Hide resolved
@skarimo skarimo merged commit 206d153 into master Feb 8, 2022
@skarimo skarimo deleted the rberger/SYA-1350/synthetics-options branch February 8, 2022 18:33
@therve therve mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maycmlee maycmlee maycmlee left review comments

@skarimo skarimo skarimo approved these changes

@AlaricCalmette AlaricCalmette AlaricCalmette left review comments

Assignees
No one assigned
Labels
changelog/improvement ci/integrations resource/datadog_synthetics_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romainberger @AlaricCalmette @maycmlee @skarimo @therve