Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump datadog-api-client-go and deprecate agent_rule field #1318

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Bump datadog-api-client-go and deprecate agent_rule field #1318

merged 2 commits into from
Jan 4, 2022

Conversation

jirikuncar
Copy link
Contributor

No description provided.

@jirikuncar jirikuncar requested review from a team as code owners January 4, 2022 11:24
@jirikuncar jirikuncar force-pushed the jirikuncar/bump-go-client branch from a1f1154 to 7094993 Compare January 4, 2022 11:27
andpiccione
andpiccione reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@andpiccione andpiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this 🙇 LGTM, but shouldn't we also modify tests&cassettes and update documentation accordingly?

@jirikuncar jirikuncar requested a review from andpiccione January 4, 2022 11:55
andpiccione
andpiccione approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@andpiccione andpiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can you also re-run make docs? I think markdown files should be updated following the field deprecation

@jirikuncar
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jirikuncar jirikuncar enabled auto-merge (squash) January 4, 2022 12:51
@jirikuncar
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jirikuncar jirikuncar merged commit e3a8da8 into master Jan 4, 2022
@jirikuncar jirikuncar deleted the jirikuncar/bump-go-client branch January 4, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andpiccione andpiccione andpiccione approved these changes

@therve therve therve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jirikuncar @therve @andpiccione