Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slo-correction examples #1307

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Fix slo-correction examples #1307

merged 4 commits into from
Jan 10, 2022

Conversation

therve
Copy link
Contributor

@therve therve commented Dec 15, 2021

SSIA

@therve therve requested a review from a team as a code owner December 15, 2021 13:43
athap
athap previously approved these changes Dec 15, 2021
View reviewed changes
Copy link

@athap athap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

iminoso
iminoso previously approved these changes Dec 15, 2021
View reviewed changes
skarimo
skarimo previously approved these changes Dec 15, 2021
View reviewed changes
@therve therve dismissed stale reviews from skarimo, iminoso, and athap via 575cc5a December 21, 2021 08:05
@therve therve merged commit 543af39 into master Jan 10, 2022
@therve therve deleted the therve/slo-doc branch January 10, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengshizhao zhengshizhao zhengshizhao left review comments

@jirikuncar jirikuncar jirikuncar approved these changes

@skarimo skarimo skarimo left review comments

@iminoso iminoso iminoso left review comments

@athap athap athap left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@therve @jirikuncar @athap @iminoso @zhengshizhao @skarimo