Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle notify_list diffs for dashboard resource #1295

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Handle notify_list diffs for dashboard resource #1295

merged 3 commits into from
Dec 3, 2021

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Dec 2, 2021

Closes 1290

@skarimo skarimo requested review from a team as code owners December 2, 2021 21:54
therve
therve approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you handle the issue in the dashboard resource as well? I think there just changing to TypeSet worked for me. You can do it in a follow up PR.

@skarimo
Copy link
Member Author

skarimo commented Dec 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@skarimo skarimo merged commit 6787e5c into master Dec 3, 2021
@skarimo skarimo deleted the sherz/notify-list branch December 3, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle perpetual diff on notify list order changes
2 participants
@skarimo @therve