Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark target_display and warning_display display values as computed #1286

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Nov 24, 2021

Those values are ignored by the API if specified in PUT/POST request.
Can break user's existing configuration if they specified those in their configuration, as terraform won't allow setting computed values.
Simply removing the value from the configuration would fix that.

Fix #1284

@zippolyte zippolyte requested review from a team as code owners November 24, 2021 10:25
@zippolyte zippolyte requested a review from a team as a code owner November 24, 2021 10:29
@zippolyte
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jirikuncar jirikuncar changed the title Mark target_display and warning_display display values as computed Mark target_display and warning_display display values as computed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service level objective - target_display and warning_display are ignored
2 participants