[examples] Fix invalid monitor timeout_h example #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathispesch
previously approved these changes
Nov 19, 2021
| @@ -18,7 +18,7 @@ resource "datadog_monitor" "foo" { | |||
| renotify_interval = 60 | |||
|
|
|||
| notify_audit = false | |||
| timeout_h = 60 | |||
| timeout_h = 18 | |||
There was a problem hiding this comment.
Do we actually want to have this in the example? There's a bunch of fields that aren't populated here already and I don't know if the autoresolve timeout is a behaviour that people want to have by default.
There was a problem hiding this comment.
fair enough, i've removed it entirely
phillip-dd
force-pushed
the
pb/fix-monitor-example-timeout
branch
from
3564e57 to
81f377d
Compare
`timeout_h` values greater than 24 hours are not supported. This example has unfortunately led to many invalid monitors.
phillip-dd
force-pushed
the
pb/fix-monitor-example-timeout
branch
from
81f377d to
2482b90
Compare
therve
approved these changes
Nov 23, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeout_hvalues greater than 24 hours are not supported. This example has unfortunately led to many invalid monitors.