Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safeguard against empty widget requests #1253

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

therve
Copy link
Contributor

@therve therve commented Oct 27, 2021

Empty request blocks are invalid, but will crash the plugin if passed
down. This protects against it so that we get the error message from the
server.

Fixes #1249

Empty request blocks are invalid, but will crash the plugin if passed
down. This protects against it so that we get the error message from the
server.

Fixes #1249
@therve therve requested review from a team as code owners October 27, 2021 10:13
@therve
Copy link
Contributor Author

therve commented Oct 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve merged commit a624a5f into master Oct 27, 2021
@therve therve deleted the therve/empty-requests branch October 27, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog Dashboard creation failed with plugin crash
2 participants