Correct downtime.monitor_tags description
#1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description on how to make use of `monitor_tags` is incorrect. From the Downtime [docs](https://docs.datadoghq.com/monitors/notify/downtimes/?tab=bymonitortags): > Schedule a downtime based on one or more monitor tags. You must select at least one tag with a limit of 32 tags. Each tag can be at most 256 characters long. Only monitors that have ALL selected tags are silenced. You can also select scopes for additional constraints. The corrected version matches the UI usage and I am also using the Terraform version in a production environment
|
If you accept this, mind adding the |
kayayarai
previously approved these changes
Oct 26, 2021
|
Hi, our docs are auto generated. Instead of updating the docs directly, could you update the description here https://github.com/DataDog/terraform-provider-datadog/blob/master/datadog/resource_datadog_downtime.go#L248 and run |
|
@skarimo should be good now |
skarimo
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description on how to make use of
monitor_tagsis incorrect.From the Downtime docs:
The corrected version matches the UI usage and I am also using the Terraform version in a production environment