Fix docs and example for security monitoring default rule #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example mentioned rule_id which is not a parameter. I also re-enforced the fact that it can't be created. Closes #1243
adussarps
reviewed
Oct 21, 2021
| @@ -8,13 +8,12 @@ description: |- | |||
|
|
|||
| # datadog_security_monitoring_default_rule (Resource) | |||
|
|
|||
| Provides a Datadog Security Monitoring Rule API resource for default rules. | |||
| Provides a Datadog Security Monitoring Rule API resource for default rules. It can only be imported, you can't create a default rule. | |||
There was a problem hiding this comment.
What do you mean by "it can only be imported"?
Also one note, I would write
you can only enable/disable a default rules and change it's notifications and it's filters (might be double checked by documentation thought.
There was a problem hiding this comment.
I mean it doesn't fit in the regular terraform workflow, as if you try to create the resource it will fail.
skarimo
approved these changes
Oct 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example mentioned rule_id which is not a parameter. I also
re-enforced the fact that it can't be created.
Closes #1243