Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dashboard resource's widget attribute to Optional #1224

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Oct 1, 2021

The resource submit an empty list by default so this pr sets the widget attribute to optional: https://github.com/DataDog/terraform-provider-datadog/blob/master/datadog/resource_datadog_dashboard.go#L867

This is to avoid having to provide an empty widget block when constructing a dashboard without widget. E.g.

resource "datadog_dashboard" "tfer--dashboard_uxi-002D-bcq-002D-4p7" {
  is_read_only = "false"
  layout_type  = "ordered"
  reflow_type  = "fixed"
  title        = "Test dashboard"
  widget {}
}

@skarimo skarimo requested review from a team as code owners October 1, 2021 18:33
@skarimo
Copy link
Member Author

skarimo commented Oct 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@skarimo skarimo merged commit 7f2e5ed into master Oct 6, 2021
@skarimo skarimo deleted the sherz/set-widget-to-optional branch October 6, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants