Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboards] Implement support for Change widgets using formulas and functions #1191

Merged
merged 8 commits into from
Nov 24, 2021

Conversation

DrkSephy
Copy link
Contributor

@DrkSephy DrkSephy commented Sep 1, 2021

This pull request implements support for formulas and functions in the Change dashboard widget.

@DrkSephy DrkSephy requested review from a team as code owners September 1, 2021 17:24
jtappa
jtappa previously approved these changes Sep 1, 2021
Copy link
Contributor

@jtappa jtappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 from docs team

@DrkSephy DrkSephy added the do-not-merge/WIP Do not merge this PR label Sep 1, 2021
jodiely
jodiely previously approved these changes Sep 8, 2021
@DrkSephy DrkSephy removed the do-not-merge/WIP Do not merge this PR label Nov 11, 2021
@DrkSephy DrkSephy dismissed stale reviews from jodiely and jtappa via d02911d November 11, 2021 17:43
go.mod Outdated
@@ -1,7 +1,7 @@
module github.com/terraform-providers/terraform-provider-datadog

require (
github.com/DataDog/datadog-api-client-go v1.6.0
github.com/DataDog/datadog-api-client-go v1.6.1-0.20211111153236-e7664265bffa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit is too old, can you upgrade go client again ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zippolyte I've gone ahead and updated the go client.

jodiely
jodiely previously approved these changes Nov 15, 2021
zippolyte
zippolyte previously approved these changes Nov 24, 2021
@zippolyte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

zippolyte
zippolyte previously approved these changes Nov 24, 2021
@zippolyte zippolyte enabled auto-merge (squash) November 24, 2021 12:59
@zippolyte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte zippolyte merged commit 5a835aa into master Nov 24, 2021
@zippolyte zippolyte deleted the david.leonard/formulas-functions-change-widget branch November 24, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants