[Synthetics] Add support for restricted roles for global variables #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreGuyot
previously approved these changes
Aug 19, 2021
zippolyte
requested changes
Aug 20, 2021
| @@ -48,7 +48,7 @@ func resourceDatadogSyntheticsGlobalVariable() *schema.Resource { | |||
| Sensitive: true, | |||
| }, | |||
| "secure": { | |||
| Description: "Sets the variable as secure. Defaults to `false`.", | |||
| Description: "If set to true, the value of the global variable will be hidden. Defaults to `false`.", | |||
There was a problem hiding this comment.
Going to need to run make docs
Also I think
Suggested change
| Description: "If set to true, the value of the global variable will be hidden. Defaults to `false`.", | |
| Description: "If set to true, the value of the global variable is hidden. Defaults to `false`.", |
There was a problem hiding this comment.
+1 on that, we try to avoid future tense as often as we can!
| @@ -99,6 +99,12 @@ func resourceDatadogSyntheticsGlobalVariable() *schema.Resource { | |||
| }, | |||
| }, | |||
| }, | |||
| "restricted_roles": { | |||
| Description: "A list of role identifiers to associate with the Synthetics global variable", | |||
There was a problem hiding this comment.
Suggested change
| Description: "A list of role identifiers to associate with the Synthetics global variable", | |
| Description: "A list of role identifiers to associate with the Synthetics global variable.", |
zippolyte
force-pushed
the
rberger/SYA-1073/gv-restricted-roles
branch
from
fab31c1 to
86ffa83
Compare
zippolyte
previously approved these changes
Aug 23, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…g into rberger/SYA-1073/gv-restricted-roles
…g into rberger/SYA-1073/gv-restricted-roles
…aDog/terraform-provider-datadog into rberger/SYA-1073/gv-restricted-roles
|
/azp run |
zippolyte
approved these changes
Aug 23, 2021
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for restricted roles for Synthetics global variables. This PR also updates the go clients to have access to the necessary methods.