Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboards] Implement formulas and functions support for query table widgets #1158

Merged
merged 9 commits into from
Aug 24, 2021

Conversation

DrkSephy
Copy link
Contributor

This pull request implements support for formulas and functions in the Query Table dashboard widget.

@DrkSephy DrkSephy requested review from a team as code owners July 27, 2021 19:19
cswatt
cswatt previously approved these changes Jul 27, 2021
@jirikuncar
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jirikuncar
jirikuncar previously approved these changes Jul 29, 2021
Copy link
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Can you check the comment above?

datadog/resource_datadog_dashboard.go Outdated Show resolved Hide resolved
@DrkSephy DrkSephy dismissed stale reviews from jirikuncar and matt-miller-ddog via 20258ac July 29, 2021 15:48
@jirikuncar
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrkSephy DrkSephy added the do-not-merge/WIP Do not merge this PR label Jul 29, 2021
@DrkSephy DrkSephy marked this pull request as draft July 29, 2021 18:26
@DrkSephy DrkSephy marked this pull request as ready for review August 24, 2021 14:07
@DrkSephy DrkSephy merged commit 78c9159 into master Aug 24, 2021
@DrkSephy DrkSephy deleted the david.leonard/tables-f-f branch August 24, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/WIP Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants