Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs index creation #1155

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Add logs index creation #1155

merged 6 commits into from
Jul 27, 2021

Conversation

zippolyte
Copy link
Contributor

Adds the create handler for logs index, now that the create index is publicly available

@zippolyte zippolyte requested review from a team as code owners July 26, 2021 08:08
skarimo
skarimo previously approved these changes Jul 26, 2021
@zippolyte
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte zippolyte requested a review from a team as a code owner July 27, 2021 08:32
Copy link
Member

@gabrielreid gabrielreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -3,17 +3,18 @@
page_title: "datadog_logs_index Resource - terraform-provider-datadog"
subcategory: ""
description: |-
Provides a Datadog Logs Index API resource. This can be used to create and manage Datadog logs indexes.
Provides a Datadog Logs Index API resource. This can be used to create and manage Datadog logs indexes.Note: It is not possible to delete logs indexes through Terraform, so an index remains in your account after the resource is removed from your terraform config. Reach out to support to delete a logs index.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Provides a Datadog Logs Index API resource. This can be used to create and manage Datadog logs indexes.Note: It is not possible to delete logs indexes through Terraform, so an index remains in your account after the resource is removed from your terraform config. Reach out to support to delete a logs index.
Provides a Datadog Logs Index API resource. This can be used to create and manage Datadog logs indexes. Note: It is not possible to delete logs indexes through Terraform, so an index remains in your account after the resource is removed from your terraform config. Reach out to support to delete a logs index.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review !
Since this file is generated, I can't really change it, but this part isn't rendered anyway on the terraform docs website, so it's fine :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zippolyte zippolyte merged commit ad059f8 into master Jul 27, 2021
@zippolyte zippolyte deleted the sherz/logs-index-create branch July 27, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants