Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit logs data source to dashboard resource #1152

Merged
merged 15 commits into from
Jul 26, 2021

Conversation

retsguj
Copy link
Contributor

@retsguj retsguj commented Jul 22, 2021

As in title. (only for timeseries, toplist, query value)

@retsguj retsguj changed the title Julia.gu/audit logs dashboards [audit logs] update dashboard resource with audit logs data source Jul 22, 2021
@retsguj retsguj marked this pull request as ready for review July 22, 2021 20:51
@retsguj retsguj requested review from a team as code owners July 22, 2021 20:51
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
docs/resources/dashboard.md Outdated Show resolved Hide resolved
@retsguj retsguj requested a review from ruthnaebeck July 23, 2021 14:03
@retsguj retsguj force-pushed the julia.gu/audit-logs-dashboards branch from a1f8ae1 to 2bf6bf0 Compare July 23, 2021 14:22
@retsguj
Copy link
Contributor Author

retsguj commented Jul 23, 2021

Docs review

@ruthnaebeck I tried to commit your suggested changes, but I think the CI tests do not allow me to make manual changes to auto-generated docs. So I think the wording cannot be changed.

@ruthnaebeck
Copy link
Contributor

ruthnaebeck commented Jul 23, 2021

Docs review

@ruthnaebeck I tried to commit your suggested changes, but I think the CI tests do not allow me to make manual changes to auto-generated docs. So I think the wording cannot be changed.

Ok. Can we update the schema for docs standards? I can make updates to your branch if needed.

Link to example line

DrkSephy
DrkSephy previously approved these changes Jul 23, 2021
Copy link
Contributor

@DrkSephy DrkSephy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, tested out some widget combinations. Left a few comments around formatting for tests, but other than that ✅

datadog/tests/resource_datadog_dashboard_test.go Outdated Show resolved Hide resolved
@therve therve enabled auto-merge (squash) July 26, 2021 15:51
@therve
Copy link
Contributor

therve commented Jul 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve dismissed ruthnaebeck’s stale review July 26, 2021 15:52

Changes applied

@therve therve merged commit f3d26b1 into master Jul 26, 2021
@therve therve deleted the julia.gu/audit-logs-dashboards branch July 26, 2021 16:09
@therve therve changed the title [audit logs] update dashboard resource with audit logs data source Add audit logs data source to dashboard resource Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants