[Dashboards] Fix is_column_break
issues
#1140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fix 2 issues:
is_column_break
is optional and should not be set for screenboards:The fix is to not add the
is_column_break
attribute when the value isfalse
. It seems that even if the optional value is not provided, Terraform set its by default tofalse
.Fix an infinite apply plan with the
is_column_break
attribute:When adding
is_column_break
totrue
, the internal TF state dont save it, leading to an infinite plan. This PR save the attribute value in the TF state.Add tests for the Multi-size layout
reflow_type
property and theis_column_break
attribute.View the changes
I updated lots of cassettes because the
is_column_break
is not in the dashboard payload by default now.The first file
datadog/resource_datadog_dashboard.go
and the last filedatadog/tests/resource_datadog_dashboard_test.go
are the only one I updated. To view them easily, collapse all files by holding down the alt key and clicking on the inverted caret icon in any file header. Then open only the first and the last file to review them.