Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom message on synthetics test resource #1133

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Add custom message on synthetics test resource #1133

merged 2 commits into from
Jul 1, 2021

Conversation

sdeprez
Copy link
Contributor

@sdeprez sdeprez commented Jun 29, 2021 •
edited
Loading

Update Synthetics documentation to:

  1. Add a custom message on top to warn about a migration we ran backend side, visible for users with version 3.1.0+. I created a resource template for that, inspired by default template, unfortunately I was unable to use .ExampleFile and .ImportFile (they were rendering empty 🤷‍♂️ ) so I directly referenced the proper files
  2. Update example resource file to remove deprecated variable usage

@sdeprez sdeprez force-pushed the sdeprez/updte_synthetics_docs_for_migration branch from 342e11a to afc5354 Compare June 29, 2021 15:48
@sdeprez sdeprez force-pushed the sdeprez/updte_synthetics_docs_for_migration branch 4 times, most recently from 2bc0403 to cee0502 Compare June 30, 2021 16:29
@sdeprez sdeprez force-pushed the sdeprez/updte_synthetics_docs_for_migration branch from cee0502 to bd4ed07 Compare June 30, 2021 16:29
@sdeprez sdeprez marked this pull request as ready for review June 30, 2021 16:47
@sdeprez sdeprez requested review from a team as code owners June 30, 2021 16:47
@therve therve merged commit d234694 into master Jul 1, 2021
@therve therve deleted the sdeprez/updte_synthetics_docs_for_migration branch July 1, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdeprez @therve