-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasource datadog user #1124
Datasource datadog user #1124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to rebase on top of master. There have been changes in the go client version, and the API for making requests changed a bit.
The terraform plugin SDK v2 is also used, and the signature of the read function is a little different, it return diagnostics, and takes a context as first argument too
cdf8424
to
f1a27f0
Compare
I haven't been able to record the tests because of the following error eventhough i did what was mention (multiple times).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments.
If you're having issues with recording, I can run it and push to your branch when you've addressed the comments
return fmt.Sprintf(` | ||
data "datadog_user" "test" { | ||
filter = "%s" | ||
}`, uniq) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to add the config for the resource here, and add a depends_on
in the datasource piece when you switch to a unique username
de02f5f
to
f4ea67e
Compare
Co-authored-by: Hippolyte HENRY <[email protected]>
Co-authored-by: Hippolyte HENRY <[email protected]>
335930e
to
3b3542b
Compare
I'm sorry i left so much unused code in this PR thank you so much for you review 🙏 . I tried to correct the test using your advices however can't really test them because of the previous error if u have a workaround or can record them i'll be glad 👍 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Introducing a datasource to retrieve datadog user using their email