Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retention_days and daily_limit attributes #1118

Merged
merged 5 commits into from
Jun 22, 2021

Conversation

jaredledvina
Copy link
Member

From https://docs.datadoghq.com/api/latest/logs-indexes/#create-an-index it seems like daily_limit is optional which would align with the UI as well.

@jaredledvina jaredledvina requested review from a team as code owners June 21, 2021 18:54
zippolyte
zippolyte previously approved these changes Jun 22, 2021
capucinemartin
capucinemartin previously approved these changes Jun 22, 2021
Copy link

@capucinemartin capucinemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zippolyte zippolyte dismissed stale reviews from capucinemartin and themself via 6b58cff June 22, 2021 15:11
@zippolyte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte zippolyte changed the title datadog_logs_index - daily_limit is optional Fix retention_days and daily_limit attributes Jun 22, 2021
@skarimo skarimo merged commit 88c2230 into master Jun 22, 2021
@skarimo skarimo deleted the jared.ledvina/logs-index-daily-limit-is-optional branch June 22, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants