[SMD-491] - Introduce the detections methods and the new value rules options #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adussarps
force-pushed
the
antoine.dussarps/sec_mon_provider_new_value_rules
branch
from
be85de7 to
9f1facf
Compare
adussarps
force-pushed
the
antoine.dussarps/sec_mon_provider_new_value_rules
branch
from
9f1facf to
c4441a1
Compare
adussarps
force-pushed
the
antoine.dussarps/sec_mon_provider_new_value_rules
branch
from
fd21ae7 to
aa2246b
Compare
adussarps
force-pushed
the
antoine.dussarps/sec_mon_provider_new_value_rules
branch
from
22b3d8b to
7e54075
Compare
adussarps
changed the title
adussarps
force-pushed
the
antoine.dussarps/sec_mon_provider_new_value_rules
branch
2 times, most recently
from
d59d285 to
ded55de
Compare
adussarps
force-pushed
the
antoine.dussarps/sec_mon_provider_new_value_rules
branch
from
ded55de to
ae4a752
Compare
greentruff
reviewed
Jun 25, 2021
There was a problem hiding this comment.
Can you also update the doc here? https://github.com/DataDog/terraform-provider-datadog/blob/master/docs/resources/security_monitoring_rule.md
| @@ -108,6 +116,30 @@ func datadogSecurityMonitoringRuleSchema() map[string]*schema.Schema { | |||
| Required: true, | |||
| Description: "A signal will “close” regardless of the query being matched once the time exceeds the maximum duration. This time is calculated from the first seen timestamp.", | |||
| }, | |||
|
|
|||
| "new_value_options": { | |||
There was a problem hiding this comment.
new_value would make more sense imo since this is already inside of options
There was a problem hiding this comment.
hmm; agreed; but it's the same "string" in the json api; so like this we have a direct mapping; I think it will help avoiding confusions.
zippolyte
reviewed
Jun 29, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extend the current datadog provider for security rules.
It add support for the detection method "new_value"; as for the detection method fields.
It will be followed by other PRs making the provider up to date with the current state of the API.