Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for access_key_id and secret_access_key #1101

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Jun 8, 2021

This PR adds support for the following attributes in the aws resource:

  • access_key_id
  • secret_access_key

Closes #1091 and #670

@skarimo skarimo requested review from a team as code owners June 8, 2021 17:46
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, LGTM otherwise

datadog/resource_datadog_integration_aws.go Outdated Show resolved Hide resolved
datadog/resource_datadog_integration_aws.go Outdated Show resolved Hide resolved
@zippolyte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ability to provide access_key/secret_key for AWS China
2 participants