Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero value for dns_server_port #1087

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented May 27, 2021

Terraform stores zero value of the attribute in state. During hcl generation via terraformer, the zero value is produced since it is the value stored in state which causes the resource to fail validation.

Tested resource creation with dns_server_port = 0 and the api responds accordingly and omits the value.

@skarimo skarimo requested review from a team as code owners May 27, 2021 21:12
@skarimo
Copy link
Member Author

skarimo commented Jun 15, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@skarimo skarimo merged commit e2fc6d9 into master Jun 15, 2021
@skarimo skarimo deleted the sherz/synthetics-validation branch June 15, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants