Merge master into sdk-v2 #1051
Merged
Merge master into sdk-v2 #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix typo from cases to case * Do not persist state changes when modifying bad rule case * Update default rule case notifications * align default rule case notification recipients when rule case tracked in terraform configuration * clear default rule case notification recipients when rule case removed from terraform configuration * Remove broken tests It is not possible to use both ImportState: True and Check * Revert "Remove broken tests" This reverts commit fed89bf. * Reapply test changes, re-record * Lint Co-authored-by: Alexandre Trufanow <[email protected]> Co-authored-by: Thomas Hervé <[email protected]>
Don't use removed metric
* add dashboard_json resource * refactor and use client exported request methods * lint and move helper functions to util * lint * handle diffs on computed fields * normalize json string * add tests and refactor * update go client * lint * update tests and lint * apply code review requested changes * apply code review suggestions and re-record cassettes * generate resource docs * fmt
* [dashboard datasource] Retry on 504 errors * Use TimeoutRead instead of TimeoutCreate Signed-off-by: Jared Ledvina <[email protected]>
* initial commit for metric tag configuration resource * fixed build update to properly check metric_type before setting include_percentiles * added first pass on tests for tag config resource * added first pass on example for tag config resource * changes to upgrade client to master * fmt example * fixed tag config schema and use proper id for api calls * use proper provider for test * capitalize test func name * enable unstable endpoints, remove prints, use proper id for state, check include_percentiles * add remaining diff from master merge in * cleanup comment and imports * golint * fix test to use proper metric_name * fix existing tag config check * cassettes * updated cassettes * updated cassettes and import test name * removed old cassettes * cleanup comments and unneeded changes * dont include percentiles in example * added customizeDiff function for include_percentiles option * removed completed todos * fix error message * fix error message * updated example metric name and generated docs * updated cassettes * fix cassettes for import test * update docs * update doc comment * added examples and updated docs * update description, check status code for update * update test check to check status code * update docs * added error test and cassette * updated import cassette * updated basic cassette * check status code when importing tag configuration * added test invalid import ID, update cassettes * added metrics-agg as codeowner * changes from 1st round of PR comments, first pass at handling [] tags * update import cassette * update basic cassette * change regex, change validation to use all function
…[VIZZ-1207] (#992) * Add legend_layout and legend_columns to timeseries widget def * Update timeseries widget tests * Update go deps * Record cassettes * Remove other updates * Remove unwanted cassettes changes * Make docs * Update to latest commit * List enum values in legend_layout description * add missing enum description * Make legend_columns a TypeSet * Use TypeSet properly, fix tests * Update docs Co-authored-by: Thomas Hervé <[email protected]>
Use released version
* cleanup imports * cleanup imports on all resources and tests
* add support for global_time_target * regenerate docs
* use goimports instead of fmt * use format-only
* [Synthetics] Prevent certificate update with wrong value * [Synthetics] Improve hash detection
* [Feature] Add datadog default security monitoring rule filters * review
Signed-off-by: Jared Ledvina <[email protected]>
…1012) * Update go client * [Synthetics] Add new fields to synthetics options * [Synthetics] Remove option * [Synthetics] Fix cassettes * [Synthetics] Fix missing doc
Remove the read to improve consistency and update the state directly instead.
* recreate GCP resource if certain fields are updated * lint * re-record cassettes * Set ForceNew to true for client_email as well
If params is empty, then we fail to parse the map and it ends up in a panic.
* [slack integration] Set account_name in state Signed-off-by: Jared Ledvina <[email protected]> * [slack integration] Get account name from state instead of arg Signed-off-by: Jared Ledvina <[email protected]> * add test case for import Co-authored-by: Sherzod K <[email protected]>
* [Synthetics] Use new synthetics test objects * [Synthetics] Use new endpoint to read api tests * [Synthetics] Record new cassettes for new api endpoint * Update go client * [Synthetics] Update for correct browser test * [Synthetics] Fix review * [Synthetics] Fix cassette
It shouldn't check for locked, as it's still present in the state, and thus remove the possibility of updating it.
* [Synthetics] Add support for multistep tests * [Synthetics] Review fixes * [Synthetics] Update docs * [Synthetics] Remove comments
* [Synthetics] Small fixes for synthetics * [Synthetics] Generate docs * [Synthetics] Fix cassettes
…ashboard resource (#892) * WIP * Finish formula and function metric_query * Implement most of FormulaAndFunctionProcessQuery * Update client * Ues new fields * Fix compute building * Implement a few more fields for formulas and functions event query * Add reading part * Persist data_source, compute, name and indexes to terraform state * Push changes for supporting search in formula and function event queries * Retrieve the query * Test skeleton * Implement more queries, tests * WIP group_by for EventQuery * Start working on adding formulas and event_query group_by * Update client * Fix formula support * Implement limit * Implement group_by schema for formula and function event query * Extend test suite for dashboard formula and functions * Add descriptions to all schema values for formulas and functions * Fix missing comma * More linting * Fix missing comma * Sync changes * Add missing functions * Update client * Exclude empty searches, update client * Add default to sort for matching SDK behavior * Merge with master * [screenboard] Fix outdated description (#904) Uptime widgets are no more. * Add security-monitoring team to codeowners (#869) * add security-monitoring team to codeownders * commit review changes Co-authored-by: Thomas Hervé <[email protected]> * remove trailing * Co-authored-by: Thomas Hervé <[email protected]> * Stop using read handler in create/update (#905) * Address PR review comments from Nick * Move new cassettes to test folder * Code cleanup and doc generation * Revert doc changes for other resources * Revert last doc change * Replace timeseries formula and function methods with new generic names * Merge with master, remove references to TimeSeries specific formula and function objects * Modify test names for dashboard formulas and functions, regenerate cassettes * Remove tests with old names * Regenerate dashboard doc * Remove MaxItems:1 restriction for group_by and compute properties * Add comments for ValidateStringValue * Fix reference to import in timeseries test * Add enum validation for timeseries formula and functions * Add two more validators Co-authored-by: Thomas Hervé <[email protected]> Co-authored-by: Phillip Baker <[email protected]> Co-authored-by: skarimo <[email protected]> Co-authored-by: Hippolyte HENRY <[email protected]> Co-authored-by: Nicholas Muesch <[email protected]>
* add an example for slo correction * add generated md file * correct a sentence * update message
skarimo
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.