[SDKv2] Merge master into sdk-v2 branch #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix typo from cases to case * Do not persist state changes when modifying bad rule case * Update default rule case notifications * align default rule case notification recipients when rule case tracked in terraform configuration * clear default rule case notification recipients when rule case removed from terraform configuration * Remove broken tests It is not possible to use both ImportState: True and Check * Revert "Remove broken tests" This reverts commit fed89bf. * Reapply test changes, re-record * Lint Co-authored-by: Alexandre Trufanow <[email protected]> Co-authored-by: Thomas Hervé <[email protected]>
Don't use removed metric
* add dashboard_json resource * refactor and use client exported request methods * lint and move helper functions to util * lint * handle diffs on computed fields * normalize json string * add tests and refactor * update go client * lint * update tests and lint * apply code review requested changes * apply code review suggestions and re-record cassettes * generate resource docs * fmt
* [dashboard datasource] Retry on 504 errors * Use TimeoutRead instead of TimeoutCreate Signed-off-by: Jared Ledvina <[email protected]>
* initial commit for metric tag configuration resource * fixed build update to properly check metric_type before setting include_percentiles * added first pass on tests for tag config resource * added first pass on example for tag config resource * changes to upgrade client to master * fmt example * fixed tag config schema and use proper id for api calls * use proper provider for test * capitalize test func name * enable unstable endpoints, remove prints, use proper id for state, check include_percentiles * add remaining diff from master merge in * cleanup comment and imports * golint * fix test to use proper metric_name * fix existing tag config check * cassettes * updated cassettes * updated cassettes and import test name * removed old cassettes * cleanup comments and unneeded changes * dont include percentiles in example * added customizeDiff function for include_percentiles option * removed completed todos * fix error message * fix error message * updated example metric name and generated docs * updated cassettes * fix cassettes for import test * update docs * update doc comment * added examples and updated docs * update description, check status code for update * update test check to check status code * update docs * added error test and cassette * updated import cassette * updated basic cassette * check status code when importing tag configuration * added test invalid import ID, update cassettes * added metrics-agg as codeowner * changes from 1st round of PR comments, first pass at handling [] tags * update import cassette * update basic cassette * change regex, change validation to use all function
…[VIZZ-1207] (#992) * Add legend_layout and legend_columns to timeseries widget def * Update timeseries widget tests * Update go deps * Record cassettes * Remove other updates * Remove unwanted cassettes changes * Make docs * Update to latest commit * List enum values in legend_layout description * add missing enum description * Make legend_columns a TypeSet * Use TypeSet properly, fix tests * Update docs Co-authored-by: Thomas Hervé <[email protected]>
Use released version
* cleanup imports * cleanup imports on all resources and tests
* add support for global_time_target * regenerate docs
* use goimports instead of fmt * use format-only
* [Synthetics] Prevent certificate update with wrong value * [Synthetics] Improve hash detection
skarimo
commented
Mar 25, 2021
| // Use utility method below, instead of the above one, to print out all state keys/values during test debugging | ||
| //funcs = append(funcs, CheckResourceAttr(name, key, value)) | ||
|
|
||
| // Handle TypeSet attributes |
There was a problem hiding this comment.
Workaroud to handle TypeSets since referencing them with hashes are no longer supported in terraform sdkv2
zippolyte
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.