Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: AWS Integration #76

Closed
iancward opened this issue Jun 20, 2018 · 7 comments
Closed

Feature Request: AWS Integration #76

iancward opened this issue Jun 20, 2018 · 7 comments

Comments

@iancward
Copy link
Contributor

Hi there,
The Datadog API supports configuration of the AWS integration; it would be nice to have the ability to configure it here.

@iancward
Copy link
Contributor Author

iancward commented Aug 7, 2018

Support for this was recently added as part of release v2.11.0 in go-datadog-api.
I notice that the go-datadog-api vendored module is the only vendored module pulled via gopkg.in. Does it make sense to migrate the vendor.json to just pull the tag directly from github.com?

@masci
Copy link
Contributor

masci commented Aug 20, 2018

Hi @iancward
probably a naive question but how that would be better? I'd need to change all the imports, not a big deal but curious about what we get in exchange.

@iancward
Copy link
Contributor Author

Ah, I see what you mean about having to change all the imports. I think I was mostly looking to get the vendored dependencies pulled from the same place (github.com) rather than some being pulled directly from github.com (which, via tags, lets you pin specifically to a minor release) and some being pulled from the third-party gopkg.in site.

If you're amenable to this change, I can submit a PR (assuming all tests pass) with the updated vendor.json and imports. I'm just waiting for my employer to approve me to contribute to this project.

@masci
Copy link
Contributor

masci commented Aug 20, 2018

I see, thanks! No objections from my side to vendor the github.com/ import path 👍 I do agree that would make tracking more explicit.

iancward added a commit to iancward/terraform-provider-datadog that referenced this issue Aug 23, 2018
Also switched from gopkg to retrieving package directly from github.com
Updating the client is pre-work prior to addressing DataDog#76
@iancward
Copy link
Contributor Author

Ok, feel free to take a look at #84. I'll start working on the AWS integration.

nitrocode pushed a commit to nitrocode/terraform-provider-datadog that referenced this issue Nov 3, 2018
Also switched from gopkg to retrieving package directly from github.com
Updating the client is pre-work prior to addressing DataDog#76
@masci
Copy link
Contributor

masci commented Nov 26, 2018

Update: some work is going on at https://github.com/terraform-providers/terraform-provider-datadog/pull/122, trying to push internally for adding update capabilities to the Datadog API (see zorkian/go-datadog-api#162 (comment) for context) but no ETA so far.

@masci masci added this to the 1.6.0 milestone Nov 29, 2018
@masci
Copy link
Contributor

masci commented Nov 30, 2018

Feature released with 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants