Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ruby Telemetry tests #992

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Enable Ruby Telemetry tests #992

merged 3 commits into from
Mar 30, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Mar 21, 2023

Description

Enable Tracer Telemetry test for Ruby.
This support has been merged for a while, but Ruby didn't get parametric system tests until recently.
One fix was needed for the Ruby Tracer (DataDog/dd-trace-rb#2710), but this PR can be merged as is with the @bug tag for that specific fix.
Tests will still run, but report as XPASS when succeeded. If failed, they won't break the build.

Workflow

  1. ⚠️⚠️ Create your PR as draft (we're receiving lot of PR, it saves us lot of time) ⚠️⚠️
  2. Follows the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Please refer to the documentation to run all scenarios in your PR if needed.

Once your PR is reviewed, you can merge it ! ❤️

@marcotc marcotc force-pushed the enable-ruby-telemetry branch from 313a984 to c1974df Compare March 24, 2023 20:08
@marcotc marcotc marked this pull request as ready for review March 24, 2023 20:32
@marcotc marcotc requested a review from a team as a code owner March 24, 2023 20:32
@marcotc marcotc force-pushed the enable-ruby-telemetry branch 2 times, most recently from 46f62a5 to 3fa12e6 Compare March 27, 2023 17:31
@marcotc marcotc requested a review from a team March 27, 2023 17:32
@marcotc marcotc force-pushed the enable-ruby-telemetry branch from 3fa12e6 to 397be3f Compare March 27, 2023 17:40
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Change seems reasonable!

@marcotc marcotc merged commit b24bdcb into main Mar 30, 2023
@marcotc marcotc deleted the enable-ruby-telemetry branch March 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants