Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Enable addEvent and recordException tests #2924

Closed
wants to merge 2 commits into from

Conversation

mtoffl01
Copy link
Contributor

Motivation

DataDog/dd-trace-java#7408

Changes

Enables addEvent and recordException tests for dd-trace-java 1.39.0+
Also, fixes/clarifies the parametric docs for Java.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mtoffl01 mtoffl01 mentioned this pull request Aug 26, 2024
7 tasks
@mtoffl01 mtoffl01 marked this pull request as ready for review September 5, 2024 14:33
@mtoffl01 mtoffl01 requested review from Kyle-Verhoog and a team as code owners September 5, 2024 14:33
@robertomonteromiguel
Copy link
Collaborator

There are lint failures and conflicts. I move this PR as draft

@robertomonteromiguel robertomonteromiguel marked this pull request as draft September 5, 2024 15:10
@mtoffl01 mtoffl01 closed this Sep 12, 2024
@mtoffl01 mtoffl01 deleted the mtoff/java-span-events-2 branch September 12, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants