Paginated store #30
Merged
Paginated store #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
paginated-store
branch
3 times, most recently
from
6de3b58 to
cf1e5bb
Compare
bantonsson
reviewed
Nov 17, 2020
bantonsson
reviewed
Nov 18, 2020
src/main/java/com/datadoghq/sketch/ddsketch/store/PaginatedStore.java
Outdated
Show resolved
Hide resolved
src/main/java/com/datadoghq/sketch/ddsketch/store/PaginatedStore.java
Outdated
Show resolved
Hide resolved
src/main/java/com/datadoghq/sketch/ddsketch/store/PaginatedStore.java
Outdated
Show resolved
Hide resolved
src/main/java/com/datadoghq/sketch/ddsketch/store/PaginatedStore.java
Outdated
Show resolved
Hide resolved
richardstartin
commented
Nov 18, 2020
src/main/java/com/datadoghq/sketch/ddsketch/store/PaginatedStore.java
Outdated
Show resolved
Hide resolved
richardstartin
force-pushed
the
paginated-store
branch
2 times, most recently
from
9fde60b to
08e6d7a
Compare
bantonsson
approved these changes
Nov 18, 2020
| * @param relativeAccuracy the relative accuracy guaranteed by the sketch | ||
| * @return a fast instance of {@code DDSketch} | ||
| */ | ||
| public static DDSketch fastPaginated(double relativeAccuracy) { |
There was a problem hiding this comment.
I merged #28, which moves preset sketches to DDSketches and tries to use more explicit method names. Should we go for bitwiseLinearlyInterpolatedPaginated maybe?
There was a problem hiding this comment.
Sounds good. I just rebased, perhaps we can leave it as is because the constructors allow composition for now, and, as discussed, this store doesn't come without costs for very small sketches.
richardstartin
force-pushed
the
paginated-store
branch
from
99f6d9a to
0c04635
Compare
CharlesMasson
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provides a store which avoids storing ranges of zeros by storing counts in a paginated array.
Motivation
To reduce worst case footprint when data is bimodal leading to large ranges of zeros, without affecting (or needing to reason about) relative error.
Additional Notes
I don't expect to merge this as is, because the postive-only sketch is being removed and I need somewhere to put the factory method, so expect to rebase against #28 during a review.
This can have a sizeable impact on footprint:
It would also be simple to implement a much faster merge routine which could be vectorized by Hotspot/C2 in
PaginatedStorewhich I may contribute at a later date (but I don't immediately need faster aggregation).