Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-2729] Update connectivity model with browser support #177

Merged
merged 3 commits into from
Jan 10, 2024
Merged

[RUM-2729] Update connectivity model with browser support #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e27c19
connectivity: remove interfaces from required
bcaudan Jan 9, 2024
c5af3e6
connectivity: add effective_type property
bcaudan Jan 9, 2024
b86aa1c
👌 improve effective type description
bcaudan Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/cjs/generated/rum.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,11 @@ export interface CommonProperties {
/**
* The list of available network interfaces
*/
readonly interfaces: ('bluetooth' | 'cellular' | 'ethernet' | 'wifi' | 'wimax' | 'mixed' | 'other' | 'unknown' | 'none')[];
readonly interfaces?: ('bluetooth' | 'cellular' | 'ethernet' | 'wifi' | 'wimax' | 'mixed' | 'other' | 'unknown' | 'none')[];
/**
* Cellular connection type reflecting the measured network performance
*/
readonly effective_type?: 'slow_2g' | '2g' | '3g' | '4g';
/**
* Cellular connectivity properties
*/
Expand Down
6 changes: 5 additions & 1 deletion lib/esm/generated/rum.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,11 @@ export interface CommonProperties {
/**
* The list of available network interfaces
*/
readonly interfaces: ('bluetooth' | 'cellular' | 'ethernet' | 'wifi' | 'wimax' | 'mixed' | 'other' | 'unknown' | 'none')[];
readonly interfaces?: ('bluetooth' | 'cellular' | 'ethernet' | 'wifi' | 'wimax' | 'mixed' | 'other' | 'unknown' | 'none')[];
/**
* Cellular connection type reflecting the measured network performance
*/
readonly effective_type?: 'slow_2g' | '2g' | '3g' | '4g';
/**
* Cellular connectivity properties
*/
Expand Down
4 changes: 4 additions & 0 deletions samples/rum-events/error.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@
"feature_three": 2,
"feature_four": { "foo": "bar" }
},
"connectivity": {
"status": "connected",
"effective_type": "4g"
},
"_dd": {
"format_version": 2
}
Expand Down
8 changes: 7 additions & 1 deletion schemas/rum/_common-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
"connectivity": {
"type": "object",
"description": "Device connectivity properties",
"required": ["status", "interfaces"],
"required": ["status"],
"properties": {
"status": {
"type": "string",
Expand All @@ -149,6 +149,12 @@
},
"readOnly": true
},
"effective_type": {
"type": "string",
"description": "Cellular connection type reflecting the measured network performance",
"enum": ["slow_2g", "2g", "3g", "4g"],
"readOnly": true
},
"cellular": {
"type": "object",
"description": "Cellular connectivity properties",
Expand Down
Loading