[RUM-EVENT-FORMAT][Replay] rename webview fields #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mquentin
requested review from
BenoitZugmeyer,
bcaudan,
mariusc83 and
N-Boutaib
mquentin
commented
Dec 14, 2023
There was a problem hiding this comment.
git mv did not go well here in the diff.
_webview-supported... naming was erroneous as other environments could later have slots (iframe...)
mquentin
commented
Dec 14, 2023
| { | ||
| "properties": { | ||
| "slotId": { | ||
| "type": "string", |
There was a problem hiding this comment.
Discussed with @mariusc83 string are more reliable that integer (cf. int64 non supported long number in javascript issue)
mquentin
commented
Dec 14, 2023
| "type": "integer", | ||
| "description": "Defines the unique ID of the replayed webview environment that will be nested in this container.", | ||
| "slotId": { | ||
| "type": "string", |
There was a problem hiding this comment.
Discussed with @mariusc83 string are more reliable that integer (cf. int64 non supported long number in javascript issue)
mquentin
commented
Dec 14, 2023
| "type": "integer", | ||
| "description": "Defines the unique ID of the replayed webview environment that will be nested in this container.", | ||
| "slotId": { | ||
| "type": "string", |
There was a problem hiding this comment.
Discussed with @mariusc83 string are more reliable that integer (cf. int64 non supported long number in javascript issue)
mariusc83
previously approved these changes
Dec 14, 2023
bcaudan
reviewed
Dec 15, 2023
schemas/session-replay/common/_slot-supported-common-record-schema.json
Outdated
Show resolved
Hide resolved
bcaudan
approved these changes
Dec 15, 2023
mariusc83
approved these changes
Dec 15, 2023
hugolevyy
approved these changes
Dec 15, 2023
BenoitZugmeyer
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following internal discussions, the PR aligns the naming of the webview concepts.
On top of this, it migrates the number based id to a string to get rid of the int32 Native problematic