Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve context in error advice messages #467

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

RomainMuller
Copy link
Contributor

Provide more context information in the error messages propagated from advice application errors, so that they are easier to troubleshoot. These messages aim to provide a lineage that allows maintainers to know exactly what advice failed, on what file.

Provide more context information in the error messages propagated from
advice application errors, so that they are easier to troubleshoot.
These messages aim to provide a lineage that allows maintainers to know
exactly what advice failed, on what file.
@RomainMuller RomainMuller requested a review from a team as a code owner December 16, 2024 10:56
@RomainMuller RomainMuller added this pull request to the merge queue Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.96%. Comparing base (4d4eb9b) to head (295e46f).

Files with missing lines Patch % Lines
internal/injector/aspect/advice/assign.go 0.00% 2 Missing ⚠️
internal/injector/aspect/advice/block.go 0.00% 2 Missing ⚠️
internal/injector/aspect/advice/call.go 0.00% 2 Missing ⚠️
internal/injector/aspect/advice/wrap.go 0.00% 2 Missing ⚠️
internal/injector/injector.go 33.33% 2 Missing ⚠️
internal/injector/aspect/advice/inject.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files         184      184           
  Lines       11084    11084           
=======================================
  Hits         7090     7090           
  Misses       3461     3461           
  Partials      533      533           
Components Coverage Δ
Generators 76.15% <ø> (ø)
Instruments 73.41% <ø> (ø)
Go Driver 78.62% <ø> (ø)
Toolexec Driver 74.28% <ø> (ø)
Aspects 78.75% <0.00%> (ø)
Injector 77.27% <8.33%> (ø)
Job Server 67.07% <ø> (ø)
Integration Test Suite 57.48% <ø> (ø)
Other 63.96% <8.33%> (ø)
Files with missing lines Coverage Δ
internal/injector/aspect/advice/inject.go 80.00% <0.00%> (ø)
internal/injector/aspect/advice/assign.go 75.00% <0.00%> (ø)
internal/injector/aspect/advice/block.go 76.00% <0.00%> (ø)
internal/injector/aspect/advice/call.go 82.90% <0.00%> (ø)
internal/injector/aspect/advice/wrap.go 80.64% <0.00%> (ø)
internal/injector/injector.go 77.19% <33.33%> (ø)

Merged via the queue into main with commit c28ad40 Dec 16, 2024
38 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/template-error-ctx branch December 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants