Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(injector: builtin: net-http-client): treat 4XX as errors, not 5XXs #426

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

eliottness
Copy link
Contributor

No description provided.

Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness marked this pull request as ready for review November 26, 2024 12:15
@eliottness eliottness requested a review from a team as a code owner November 26, 2024 12:15
@eliottness eliottness added this pull request to the merge queue Nov 26, 2024
RomainMuller added a commit to DataDog/documentation that referenced this pull request Nov 26, 2024
Merged via the queue into main with commit 64b5659 Nov 26, 2024
34 checks passed
@eliottness eliottness deleted the eliottness/fix-net-http-client-errors branch November 26, 2024 13:50
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@089b251). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage        ?   63.95%           
=======================================
  Files           ?      181           
  Lines           ?    10956           
  Branches        ?        0           
=======================================
  Hits            ?     7007           
  Misses          ?     3426           
  Partials        ?      523           
Components Coverage Δ
Generators 76.69% <ø> (?)
Instruments 73.41% <ø> (?)
Go Driver 80.16% <ø> (?)
Toolexec Driver 73.59% <ø> (?)
Aspects 78.57% <ø> (?)
Injector 77.13% <ø> (?)
Job Server 67.26% <ø> (?)
Integration Test Suite 57.58% <100.00%> (?)
Other 63.95% <100.00%> (?)
Files with missing lines Coverage Δ
_integration-tests/tests/net_http/client_error.go 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants