Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename dd:ignore to orchestrion:ignore #405

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

RomainMuller
Copy link
Contributor

The //orchestrion:ignore directive replaces //dd:ignore to make it clear that it opts the node tree out of any orchestrion processing, and not just of datadog integrations.

The dd:ignore directive continues to work, but a warning will be emitted when it is encountered, prompting users to update their code.

The `//orchestrion:ignore` directive replaces `//dd:ignore` to make it
clear that it opts the node tree out of any orchestrion processing, and
not just of datadog integrations.

The `dd:ignore` directive continues to work, but a warning will be
emitted when it is encountered, prompting users to update their code.
@RomainMuller RomainMuller requested a review from a team as a code owner November 19, 2024 16:51
README.md Outdated Show resolved Hide resolved
docs/content/docs/custom-trace.md Show resolved Hide resolved
internal/injector/labels.go Show resolved Hide resolved
@RomainMuller RomainMuller added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 49288e7 Nov 20, 2024
25 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/orchestrion-ignore branch November 20, 2024 12:16
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.77%. Comparing base (9cae407) to head (af182e0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/injector/labels.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   60.31%   60.77%   +0.46%     
==========================================
  Files         179      181       +2     
  Lines       12593    12707     +114     
==========================================
+ Hits         7595     7723     +128     
+ Misses       4500     4453      -47     
- Partials      498      531      +33     
Components Coverage Δ
Generators 76.72% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.94% <ø> (ø)
Toolexec Driver 70.66% <ø> (ø)
Aspects 71.50% <ø> (-0.39%) ⬇️
Injector 71.87% <62.50%> (-0.35%) ⬇️
Job Server 66.14% <ø> (+4.10%) ⬆️
Integration Test Suite 54.24% <100.00%> (ø)
Other 60.77% <70.00%> (+0.46%) ⬆️
Files with missing lines Coverage Δ
_integration-tests/tests/chi.v5/chi.go 100.00% <100.00%> (ø)
_integration-tests/tests/gcp_pubsub/gcp_pubsub.go 92.30% <100.00%> (ø)
internal/injector/injector.go 74.28% <100.00%> (ø)
internal/injector/labels.go 54.54% <57.14%> (-45.46%) ⬇️

... and 25 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants