feat: new built.WithOrchestrion constant
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose a `built.WithOrchestrion` constant so that usages where it is possible to take a direct dependency on `github.com/DataDog/orchestrion` is possible are simpler; as a readily available variable is provided. This reduces the amount of places where the `//dd:orchestrion-enabled` directive is necessary, which may improve compilation speeds (as directive join points may be dispandious to evaluate).
eliottness
requested changes
Nov 8, 2024
internal/injector/builtin/yaml/directive/orchestrion-enabled.yml
Outdated
Show resolved
Hide resolved
eliottness
approved these changes
Nov 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 60.81% 60.85% +0.04%
==========================================
Files 174 174
Lines 12302 12341 +39
==========================================
+ Hits 7481 7510 +29
- Misses 4340 4350 +10
Partials 481 481
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a
built.WithOrchestrionconstant so that usages where it is possible to take a direct dependency ongithub.aaakk.us.kg/DataDog/orchestrionis possible are simpler; as a readily available variable is provided.This reduces the amount of places where the
//dd:orchestrion-enableddirective is necessary, which may improve compilation speeds (as directive join points may be dispandious to evaluate).