Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ensure): packages.Load().Module is nil #372

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Oct 30, 2024

Fixes #371

See golang/go#65816

@eliottness eliottness marked this pull request as ready for review November 4, 2024 12:51
@eliottness eliottness requested a review from a team as a code owner November 4, 2024 12:51
@eliottness eliottness added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit e8e08e1 Nov 4, 2024
23 checks passed
@eliottness eliottness deleted the eliott.bouhana/version-check-segv branch November 4, 2024 15:26
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.91%. Comparing base (35b17c0) to head (8200d88).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/ensure/requiredversion.go 0.00% 2 Missing and 1 partial ⚠️
internal/pin/pin.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   59.21%   58.91%   -0.30%     
==========================================
  Files         159      160       +1     
  Lines       11423    11503      +80     
==========================================
+ Hits         6764     6777      +13     
- Misses       4162     4248      +86     
+ Partials      497      478      -19     
Components Coverage Δ
Generators 76.98% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.13% <ø> (ø)
Toolexec Driver 70.64% <ø> (ø)
Aspects 71.28% <ø> (+0.11%) ⬆️
Injector 73.40% <ø> (+0.07%) ⬆️
Job Server 64.02% <ø> (-3.55%) ⬇️
Integration Test Suite 50.42% <ø> (+0.60%) ⬆️
Other 58.91% <70.58%> (-0.30%) ⬇️
Files with missing lines Coverage Δ
internal/pin/pin.go 58.25% <85.71%> (-1.37%) ⬇️
internal/ensure/requiredversion.go 67.44% <0.00%> (-4.85%) ⬇️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] version check SEGV in toolexec mode on go 1.23
2 participants