feat: support github.com/sirupsen/logrus #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarguelloF
changed the title
RomainMuller
approved these changes
Nov 6, 2024
Comment on lines
+86
to
+89
| func(logger logrus.Logger) logrus.Logger { | ||
| logger.AddHook(&logrus.DDContextLogHook{}) | ||
| return logger | ||
| }({{ . }}) |
There was a problem hiding this comment.
I don't love how this appears to be making more copies than strictly necessary; but I reckon I might be overly pessimistic with how the compiler will treat that, and I don't think this is a line that ought to be on a hot path anyway...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 60.28% 60.66% +0.37%
==========================================
Files 166 171 +5
Lines 11973 12087 +114
==========================================
+ Hits 7218 7332 +114
Misses 4280 4280
Partials 475 475
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.