all: Add integration testing harness and some tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
force-pushed
the
knusbaum/integration-tests
branch
2 times, most recently
from
edc3c8d to
c9eb5b8
Compare
knusbaum
changed the title
knusbaum
force-pushed
the
knusbaum/integration-tests
branch
from
c9eb5b8 to
30f6437
Compare
knusbaum
changed the title
This commit adds an integration test harness to the repository. Individual tests consist of a directory under _integration-tests/tests which contains a go program and a file, validation.json. The go program will be instrumented by orchestrion, then run. The traces output by that program go to a fake agent, which records the traces. The validation.json file describes the expected structure of the traces which should be produced by each test. This includes things like name, resource, service, metadata and metrics. Once the traces are recorded and the test program shuts down, the traces recorded by the fake agent are checked against the expected ones described in validation.json to ensure the test produced exactly what we expected, in terms of the number of traces, the structure of those traces, and the fields in the spans of the traces.
knusbaum
force-pushed
the
knusbaum/integration-tests
branch
from
c2b2f06 to
0772417
Compare
ahmed-mez
reviewed
Sep 7, 2023
ahmed-mez
reviewed
Sep 7, 2023
ahmed-mez
reviewed
Sep 7, 2023
|
@knusbaum I've a similar set of comments that @ahmed-mez already wrote, so I won't duplicate them. My only addition would be: could it be interesting to document any specifics about these integration tests when adding new contribs? |
ahmed-mez
reviewed
Sep 8, 2023
ahmed-mez
reviewed
Sep 18, 2023
|
@ahmed-mez @darccio I also cleaned up the github action. I ended up removing the explicit cache since it looks like the setup-go cache is mostly working, and it simplifies the setup. Ready to merge. |
ahmed-mez
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit adds an integration test harness to the repository.
Individual tests consist of a directory under _integration-tests/tests
which contains a go program and a file, validation.json.
The go program will be instrumented by orchestrion, then run. The traces
output by that program go to a fake agent, which records the traces.
The validation.json file describes the expected structure of the traces
which should be produced by each test. This includes things like name,
resource, service, metadata and metrics.
Once the traces are recorded and the test program shuts down, the traces
recorded by the fake agent are checked against the expected ones
described in validation.json to ensure the test produced exactly what we
expected, in terms of the number of traces, the structure of those
traces, and the fields in the spans of the traces.
Motivation
Reviewer's Checklist