Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument: support gorilla/mux #36

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

darccio
Copy link
Member

@darccio darccio commented Aug 24, 2023

What does this PR do?

Support github.com/gorilla/mux by detecting the instantiation of mux.NewRouter and replacing it with the Gorilla wrapper from dd-trace-go.

image

Trace in DDev

Reviewer's Checklist

  • Changed code has unit tests for its functionality.

@darccio darccio requested review from knusbaum and ahmed-mez August 24, 2023 10:01
@darccio darccio force-pushed the dario.castane/AIT-8149/gorilla-mux branch from cf9854b to 77745aa Compare August 24, 2023 10:04
@darccio darccio marked this pull request as draft August 24, 2023 13:05
@darccio darccio force-pushed the dario.castane/AIT-8149/gorilla-mux branch from 77745aa to f76a719 Compare August 25, 2023 08:57
@darccio darccio marked this pull request as ready for review August 25, 2023 08:57
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's update the supported contribs list in the readme as well!

@darccio darccio force-pushed the dario.castane/AIT-8149/gorilla-mux branch 2 times, most recently from 9c2583e to 73ea9c9 Compare August 25, 2023 13:25
@darccio darccio force-pushed the dario.castane/AIT-8149/gorilla-mux branch from 73ea9c9 to e52de70 Compare August 25, 2023 13:26
@darccio darccio merged commit 8cceb15 into main Aug 25, 2023
@darccio darccio deleted the dario.castane/AIT-8149/gorilla-mux branch August 25, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants