feat: code templates can declare required go langage level #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases, it is not practical to write aspects using go syntax that is known to work with all go versions. While this is in general not an issue (since `orchestrion` only supports the latest 2 go releases), it can still cause issues when injecting code into modules with a `go.mod` file that declares an antiquated `go` version (e.g: `go 1.13`). In such cases, go 1.22 and newer toolchains will instruct the compiler to process the source code in a way that ensures compatibility with that antiquated language level, prohibiting use of newer language features. To protect ourselves from this issue, the `template` objects can now be configured to demand a certain minimum language level to be available, which will cause compile units into which that template generated code to have the compiler's `-lang` flag set to that level (unless it was already set at a higher level). This might have consequences on the behavior of the compiled code (e.g, the change of `for range` variable bindings introduced in go 1.22); but we currently do not deal with this particular issue, as we assume it will seldom have any practical impact in our use-cases.
RomainMuller
changed the title
rarguelloF
reviewed
Oct 25, 2024
| @@ -44,15 +44,29 @@ imports: | |||
| tracer: gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer | |||
| ``` | |||
|
|
|||
| ### Links | |||
There was a problem hiding this comment.
Why is Links disappearing? is this intentional?
There was a problem hiding this comment.
It was never there to begin with! It's only supported for inject-declarations...
eliottness
reviewed
Oct 29, 2024
RomainMuller
force-pushed
the
romain.marcadier/template-go-lang
branch
from
e69e70c to
9910926
Compare
eliottness
approved these changes
Oct 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 58.50% 58.63% +0.13%
==========================================
Files 158 159 +1
Lines 11333 11423 +90
==========================================
+ Hits 6630 6698 +68
- Misses 4232 4249 +17
- Partials 471 476 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, it is not practical to write aspects using go syntax that is known to work with all go versions. While this is in general not an issue (since
orchestriononly supports the latest 2 go releases), it can still cause issues when injecting code into modules with ago.modfile that declares an antiquatedgoversion (e.g:go 1.13).In such cases, go 1.22 and newer toolchains will instruct the compiler to process the source code in a way that ensures compatibility with that antiquated language level, prohibiting use of newer language features.
To protect ourselves from this issue, the
templateobjects can now be configured to demand a certain minimum language level to be available, which will cause compile units into which that template generated code to have the compiler's-langflag set to that level (unless it was already set at a higher level).This might have consequences on the behavior of the compiled code (e.g, the change of
for rangevariable bindings introduced in go 1.22); but we currently do not deal with this particular issue, as we assume it will seldom have any practical impact in our use-cases.