Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support github.com/twitchtv/twirp #352

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 23, 2024

Adds support for github.com/twitchtv/twirp

@rarguelloF rarguelloF marked this pull request as ready for review October 23, 2024 11:33
@rarguelloF rarguelloF requested a review from a team as a code owner October 23, 2024 11:33
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind doing a samples/server/twirp.go example file ?

internal/injector/builtin/yaml/rpc/twirp.yml Outdated Show resolved Hide resolved
internal/injector/builtin/yaml/rpc/twirp.yml Show resolved Hide resolved
@rarguelloF rarguelloF added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit ddeab4f Oct 31, 2024
23 checks passed
@rarguelloF rarguelloF deleted the rarguellof/APPSEC-55050/twirp branch October 31, 2024 11:47
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.90%. Comparing base (70d4d28) to head (cc63301).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
_integration-tests/tests/twirp/twirp.go 96.15% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   62.37%   58.90%   -3.48%     
==========================================
  Files         156      160       +4     
  Lines        9790    11501    +1711     
==========================================
+ Hits         6107     6775     +668     
- Misses       3183     4249    +1066     
+ Partials      500      477      -23     
Components Coverage Δ
Generators 76.98% <ø> (-1.41%) ⬇️
Instruments 88.05% <ø> (ø)
Go Driver 73.13% <ø> (-7.11%) ⬇️
Toolexec Driver 70.64% <ø> (-3.79%) ⬇️
Aspects 71.28% <ø> (-6.17%) ⬇️
Injector 73.40% <ø> (-4.19%) ⬇️
Job Server 63.45% <ø> (-9.28%) ⬇️
Integration Test Suite 50.42% <96.15%> (-1.45%) ⬇️
Other 58.90% <96.15%> (-3.48%) ⬇️
Files with missing lines Coverage Δ
_integration-tests/tests/twirp/twirp.go 96.15% <96.15%> (ø)

... and 135 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants