-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(injector: redigo) fix bad argument type from []redis.DialOption to []any #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to []any Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliott.bouhana/cast-redigo-optiosn
branch
from
October 22, 2024 16:26
c7d5bdb
to
c408cea
Compare
eliottness
changed the title
fix(injectoe: redigo) fix bad argument type from []redigo.DialOption to []any
fix(injector: redigo) fix bad argument type from []redigo.DialOption to []any
Oct 22, 2024
eliottness
changed the title
fix(injector: redigo) fix bad argument type from []redigo.DialOption to []any
fix(injector: redigo) fix bad argument type from []redis.DialOption to []any
Oct 22, 2024
darccio
approved these changes
Oct 23, 2024
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliott.bouhana/cast-redigo-optiosn
branch
from
October 23, 2024 11:42
ba08808
to
37916d3
Compare
RomainMuller
approved these changes
Oct 23, 2024
Signed-off-by: Eliott Bouhana <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 61.06% 57.91% -3.15%
==========================================
Files 151 153 +2
Lines 9544 11124 +1580
==========================================
+ Hits 5828 6443 +615
- Misses 3246 4213 +967
+ Partials 470 468 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
Fix
github.com/gomodule/redigo/redis
aspects where adding options ahead of making calls would fail the build because of the differences of signatures between the original and replaced function:Original DialURL function:
dd-trace-go DialURL function:
Therefore we need to cast the args before sending them to dd-trace-go