fix: //dd:span on func main() does not work
#316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the tracer was started at the start of the `main` function, a `//dd:span` annotation there may not have been honored, depending on the order in which aspects were woven into the file. This PR mvoes the tracer initialization to a `func init()` function, so that it happens strictly before the `main` function starts executing, making it possible to `//dd:span` the `main` function reliably.
eliottness
approved these changes
Oct 3, 2024
nsrip-dd
requested changes
Oct 3, 2024
…he end of their respective init blocks
nsrip-dd
approved these changes
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 57.93% 61.04% +3.11%
==========================================
Files 151 149 -2
Lines 10973 9419 -1554
==========================================
- Hits 6357 5750 -607
+ Misses 4149 3199 -950
- Partials 467 470 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tracer was started at the start of the
mainfunction, a//dd:spanannotation there may not have been honored, depending on the order in which aspects were woven into the file.This PR mvoes the tracer initialization to a
func init()function, so that it happens strictly before themainfunction starts executing, making it possible to//dd:spanthemainfunction reliably.