Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for gcp pubsub #266

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Sep 10, 2024

Adds support for instrumenting cloud.google.com/go/pubsub

Requires DataDog/dd-trace-go#2852

@rarguelloF rarguelloF marked this pull request as ready for review September 23, 2024 09:47
@rarguelloF rarguelloF requested a review from a team as a code owner September 23, 2024 09:47
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomainMuller RomainMuller added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit b610c54 Sep 23, 2024
22 checks passed
@RomainMuller RomainMuller deleted the rarguellof/APPSEC-53291/support-pubsub-3 branch September 23, 2024 11:05
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 92.38095% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.87%. Comparing base (c6451d2) to head (20ac6f0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
_integration-tests/tests/gcp_pubsub/gcp_pubsub.go 92.38% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   73.48%   73.87%   +0.38%     
==========================================
  Files         144      145       +1     
  Lines        7861     7966     +105     
==========================================
+ Hits         5777     5885     +108     
+ Misses       1655     1653       -2     
+ Partials      429      428       -1     
Components Coverage Δ
Generators 76.69% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 72.81% <ø> (ø)
Toolexec Driver 70.88% <ø> (ø)
Aspects 71.95% <ø> (+0.15%) ⬆️
Injector 73.42% <ø> (+0.17%) ⬆️
Job Server 63.76% <ø> (+0.56%) ⬆️
Integration Test Suite 87.84% <92.38%> (+0.20%) ⬆️
Other 73.87% <92.38%> (+0.38%) ⬆️
Files with missing lines Coverage Δ
_integration-tests/tests/gcp_pubsub/gcp_pubsub.go 92.38% <92.38%> (ø)

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants